Increase the project manager's default window size #91889
Conversation
Calinou
force-pushed
the
project-manager-tweak-default-window-size
branch
2 times, most recently
from
7236926 to
c23000a
Compare
| if (!force_res && project_manager) { | ||
| // Ensure splash screen size matches the project manager window size | ||
| // (see `editor/project_manager.cpp` for defaults). | ||
| window_size.width = ProjectManager::DEFAULT_WINDOW_WIDTH; | ||
| window_size.height = ProjectManager::DEFAULT_WINDOW_HEIGHT; | ||
| } |
There was a problem hiding this comment.
If you are doing this anyway, can you have it initialize EDSCALE earlier and have the initial size take it into account?
There was a problem hiding this comment.
This should be done in a separate PR as per @badsectoracula's comment (it's quite a bit more complex).
|
I did check this and it seems to work as expected and is more comfortable. Also checked with scaling, etc. It seems to work fine with both very large scaling and small DPI:
(though the main editor window isn't as accommodating at tiny resolutions) I also checked what @alvinhochun suggested above about matching splash screen size for other scale factors than 1.0, it seems like EDSCALE would be set up way down the road so it'd either need yet another copy/paste of the scale setup logic (i've noticed at least a couple of those) or bringing the logic in a single place that is initialized very early (and perhaps updated later if needed, just not by copy/pasting the same code). Either case i think it'd be outside the scope of this PR. |
This makes the project manager feel less cramped when many projects are imported, or when browsing templates in the asset library. On displays smaller than 1152x800 (e.g. 1366x768), window height is automatically limited by DisplayServer when setting the window size. This also tweaks splash screen size when starting the project manager to match the project manager's default window size, and allows the `--resolution` and `--position` CLI arguments to affect the project manager. Lastly, this increases the minimum width slightly to prevent the UI from being cut off with the default theme.
Calinou
force-pushed
the
project-manager-tweak-default-window-size
branch
from
c23000a to
cc86322
Compare
|
Thanks! |
|
Pulled from master and immediately noticed that the project manager's default window size had shrunk significantly. 
This is on macOS with 200% scaling, perhaps there is a |
This makes the project manager feel less cramped when many projects are imported, or when browsing templates in the asset library.
On displays smaller than 1152×800 (e.g. 1366×768), window height is automatically limited by DisplayServer when setting the window size.
This also tweaks splash screen size when starting the project manager to match the project manager's default window size, and allows the
--resolutionand--positionCLI arguments to affect the project manager.Lastly, this increases the minimum width slightly to prevent the UI from being cut off with the default theme.
Preview