-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCons: Fix silence_msvc
implementation errors
#91890
SCons: Fix silence_msvc
implementation errors
#91890
Conversation
Potential issues:
Postscript I realize that the stream checks are similar to those in the SCons platform win32.py code. IMHO, using Unless I'm missing something, which is always possible, the following are equivalent:
|
d06ecc1
to
c1770ee
Compare
Hot damn, you're on a roll with these insights! Went ahead and expanded the logic to incorporate those points & a few other improvements:
|
Looks good. Suggestions:
Optional enhancements, feel free to ignore:
|
c1770ee
to
45357cd
Compare
Did a few fresh builds & everything's working as expected! |
45357cd
to
0ec4ec0
Compare
Thanks! |
Fixes #91883
My eyes have been opened to how futile it is to consolidate logic on this
silence_msvc
nonsense, sostdout
is gonna be more explicitly parsed now. Namely, the decoding now happens immediately & each line is checked individually for potential bloat capture. In the interest of keeping this somewhat restrained, the checks are tailored for this repository where appropriate & warnings are given when this is the case.