Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scene] Add SceneStringNames::panel #91950

Merged
merged 2 commits into from
May 31, 2024
Merged

[Scene] Add SceneStringNames::panel #91950

merged 2 commits into from
May 31, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented May 14, 2024 •
edited
Loading

@AThousandShips AThousandShips added this to the 4.x milestone May 14, 2024
@AThousandShips AThousandShips requested review from a team as code owners May 14, 2024 14:54
@AThousandShips AThousandShips changed the title Panel sname [Scene] Add SceneStringNames::panel May 14, 2024
@AThousandShips AThousandShips mentioned this pull request May 14, 2024
Merged
@AThousandShips AThousandShips force-pushed the panel_sname branch 2 times, most recently from cb1baff to d704ac5 Compare May 14, 2024 15:00
@AThousandShips AThousandShips removed request for a team May 14, 2024 15:00
@AThousandShips AThousandShips force-pushed the panel_sname branch 2 times, most recently from 18d5c9f to fee91f7 Compare May 15, 2024 07:43
@AThousandShips AThousandShips force-pushed the panel_sname branch 2 times, most recently from b0412aa to 0421432 Compare May 30, 2024 20:27
akien-mga
akien-mga approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 30, 2024
@AThousandShips
Copy link
Member Author

Rebased on top of #91949 for conflicts, should merge safely if done in order

@akien-mga akien-mga merged commit b201c08 into godotengine:master May 31, 2024
16 checks passed
@AThousandShips AThousandShips deleted the panel_sname branch May 31, 2024 12:20
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips mentioned this pull request Jun 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @akien-mga