Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix completion for new arguments #92251

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix completion for new arguments #92251

merged 1 commit into from
May 30, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented May 22, 2024 •
edited
Loading

Works both for separated and inner classes:

изображение
изображение

@Chaosus Chaosus requested a review from a team as a code owner May 22, 2024 10:51
@Chaosus Chaosus added this to the 4.3 milestone May 22, 2024
@Chaosus Chaosus force-pushed the gdscript_fix_new_argument_completion branch 2 times, most recently from 7b9b86a to 045649e Compare May 22, 2024 11:18
@Chaosus Chaosus force-pushed the gdscript_fix_new_argument_completion branch 7 times, most recently from bf5e7a0 to 7b36114 Compare May 23, 2024 07:35
@HolonProduction
Copy link
Member

Would be nice to handle inheritance as well:
image

@Chaosus Chaosus force-pushed the gdscript_fix_new_argument_completion branch from 7b36114 to e03c8e1 Compare May 26, 2024 10:37
@Chaosus
Copy link
Member Author

Chaosus commented May 26, 2024

@HolonProduction Done, check again

@Chaosus Chaosus force-pushed the gdscript_fix_new_argument_completion branch 2 times, most recently from b2e4d51 to 33975a8 Compare May 26, 2024 10:41
@Chaosus Chaosus force-pushed the gdscript_fix_new_argument_completion branch from 33975a8 to fc2b821 Compare May 26, 2024 10:47
Calinou
Calinou approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Testing project: test_pr_92251.zip

image

akien-mga
akien-mga approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert, but looks ok to me.

@akien-mga akien-mga merged commit 2666955 into godotengine:master May 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the gdscript_fix_new_argument_completion branch May 30, 2024 09:51
@Chaosus Chaosus mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

_init() arguments are not suggested when using new()
4 participants
@Chaosus @HolonProduction @akien-mga @Calinou