Autocompletion: Keep get_node values which are compatible with type hint
#92263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
get_node values which are compatible with type hint
HolonProduction
force-pushed
the
autocompletion-get-node-set-value-if-type-compatible
branch
from
9a02a2b to
2339776
Compare
HolonProduction
force-pushed
the
autocompletion-get-node-set-value-if-type-compatible
branch
from
2339776 to
9a84387
Compare
dalexeev
added
the
cherrypick:4.3
akien-mga
approved these changes
Oct 2, 2024
|
Thanks! |
HolonProduction
deleted the
autocompletion-get-node-set-value-if-type-compatible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92219
If the node behind the literal has the same type that is annotated the type will now still be handled by
_get_subscript_typewhich means that the value on the type is set and argument options completion is possible again.