Ensure MovieWriter output is in gamma space when using HDR 2D #92496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #81301
Fixes: #82351 (this is a documentation fix)
Right now when writing out movies they have to be in 8-bit sRGB space. So when using a linear render target we need to convert to gamma space before writing.
To support doing that I had to:
viewport_is_using_hdr_2d
. This is not exposed to users as its not a good idea to call this every frame (for Movie Writer we can't avoid constant GPU stalls anyway, so it's fine)Image::linear_to_srgb()
this is a direct copy of the existingImage::srgb_to_linear()
function. (I generated the table of values usingColor::linear_to_srgb()
)Since this adds a new function let's wait until 4.4 to merge