Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AudioStreamPlayer icons, improve audio resource picker styling #92504

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

ckaiser
Copy link
Contributor

@ckaiser ckaiser commented May 29, 2024

Fixed AudioStreamPlayer/2D/3D icons not having their colors replaced by the icon loader, (same issue as in #91821, I searched in the files and this seems to be the last files with this issue, could be worth checking this in-code or pre-commit?).

Fixed the EditorStreamResourcePicker styling in light mode being broken and made some tweaks to it:

  • Added a little more padding to the icon so it's not so close to the edge when the focus ring is around it
  • Removed the colored rect that it was drawing around the preview, it looks better without it IMO
  • Fixed it using the default font color when drawing the label
Before After
before_nodes after_nodes
before_light_closed after_light_closed
before_light_closed_wav after_light_closed_wav
before_light_open after_light_open_wav
dark_light_closed_wav after_dark_closed_wav

@ckaiser ckaiser force-pushed the audiostreamplayer-light-mode branch from 80d963a to 04f6435 Compare June 27, 2024 13:59
@ckaiser
Copy link
Contributor Author

ckaiser commented Jun 27, 2024

Rebasing after the icons ended up getting fixed by #92766, so that leaves the background and margins.

@akien-mga akien-mga merged commit f662e07 into godotengine:master Jun 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants