Avoid crash when importing .glsl in headless #92539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
May 30, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this is a band-aid for a knife stab.
Given that the import process for
.glslfiles involves querying the currently active rendering driver, viaRenderingDevice, for its capabilities, it's not possible to perform such an import in headless mode. A crash due to null pointer happens. And that's what this PR patches: you are warned the import couldn't happen instead of geting a crash.However, the issue is much deeper. Which rendering driver is curently active shouldn't have an impact on how the shader from the
.glslfile is conditioned since at runtime a different one may be enabled. Re-thinking how that works is required. This PR only takes us so far.