Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Add a method for detecting signed values #92799

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

BlueCube3310
Copy link
Contributor

Adds a new detect_signed method to Image for checking whether an image has negative values. This simplifies the CVTT compression code and will be useful for #91535.

@BlueCube3310 BlueCube3310 requested review from a team as code owners June 5, 2024 14:31
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any obvious problems so it looks good to me.

@BlueCube3310 BlueCube3310 force-pushed the image-detech-signed branch from 109ffe9 to 34ecaaf Compare June 5, 2024 14:41
@BlueCube3310
Copy link
Contributor Author

Added a parameter for including mipmaps.

@Calinou Calinou added this to the 4.x milestone Jun 5, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. This method isn't exposed to scripting (but I don't see much need for it).

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 27, 2024
@akien-mga akien-mga merged commit 6e33204 into godotengine:master Aug 27, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants