Stop color picker tooltip from stealing input events #92843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input events go to the tooltip because it's added to `popup_list` in DisplayServer `popup_open`. I think there's no harm in tooltips being omitted from the list, so this commit blocks non-popup windows from being added if they have `FLAG_NO_FOCUS` and `FLAG_MOUSE_PASSTHROUGH`. I'm not happy with this way of detecting tooltips. It'll also catch other windows where this behavior may or may not be wanted. I thought about adding `FLAG_TOOLTIP`, but went with the smaller change for now. Fixes godotengine#79500.
|
I apologize for being off topic, but it seems to me that this problem is also stealing focus (#88412 ), I am not imposing the problem on you, but maybe you should take a look at the problem :) |
|
I'm sorry, but I need personal pain to motivate myself to work with C++. ^^;; Maybe if I get into UV editing in the future. |
works on macOS |
bruvzg
approved these changes
Jun 8, 2024
This might be a good idea, but current changes should work fine for tooltip. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input events go to the tooltip because it's added to
popup_listin DisplayServerpopup_open. I think there's no harm in tooltips being omitted from the list, so this commit blocks non-popup windows from being added if they haveFLAG_NO_FOCUSandFLAG_MOUSE_PASSTHROUGH.I'm not happy with this way of detecting tooltips. It'll also catch other windows where this behavior may or may not be wanted.
I thought about adding
FLAG_TOOLTIP, but went with the smaller change for now.Fixes #79500.
I don't have access to macOS so this has only been tested in Linux and Windows.