Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_concatenated_bone_names() to Skeleton3D for SkeletonModifier3D's enum hints #92925

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add get_concatenated_bone_names() to Skeleton3D for SkeletonModifier3D's enum hints #92925

merged 1 commit into from
Jun 10, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jun 9, 2024 •
edited
Loading

Follow up #91507.

Cache and expose string for enum hints of bone list. This is already applicable to some of Godot's Nodes and a little improves the performance of the editor.

@TokageItLab TokageItLab added this to the 4.3 milestone Jun 9, 2024
@TokageItLab TokageItLab requested a review from a team June 9, 2024 03:50
@TokageItLab TokageItLab requested review from a team as code owners June 9, 2024 03:50
@TokageItLab TokageItLab mentioned this pull request Jun 9, 2024
Merged
@TokageItLab TokageItLab force-pushed the concatenated-bone-names branch 2 times, most recently from e3a784b to 9a273f8 Compare June 9, 2024 09:30
@TokageItLab TokageItLab mentioned this pull request Jun 9, 2024
Merged
lyuma
lyuma reviewed Jun 9, 2024
View reviewed changes
Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I think this is an ok API to expose, since it is very useful. I was worried about calculating the bone name list during runtime when it is not needed, so I would prefer if it is updated only when used.

scene/3d/skeleton_3d.cpp Outdated Show resolved Hide resolved
scene/3d/skeleton_3d.cpp Show resolved Hide resolved
@TokageItLab TokageItLab requested a review from lyuma June 10, 2024 01:21
@akien-mga akien-mga merged commit 821338c into godotengine:master Jun 10, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the concatenated-bone-names branch June 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@lyuma lyuma lyuma approved these changes

Assignees
No one assigned
Labels
enhancement performance topic:animation topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@TokageItLab @akien-mga @lyuma @AThousandShips