Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect camera transform of animation view in the import window #92974

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix incorrect camera transform of animation view in the import window #92974

merged 1 commit into from
Jun 12, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 10, 2024 •
edited
Loading

Fixes incorrect AABB transformation of the camera of the models in animation view of the advanced import settings, which leads to clipping issues:

import_settings_bug

After the fix:

import_settings_bug_fix

@Chaosus Chaosus requested a review from a team as a code owner June 10, 2024 13:10
@Chaosus Chaosus added this to the 4.3 milestone Jun 10, 2024
@Chaosus Chaosus added topic:import cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jun 10, 2024
@akien-mga akien-mga merged commit fdb6100 into godotengine:master Jun 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the import_settings_animation_bugfix branch June 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:editor topic:import topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaosus @akien-mga