[Wayland] Implement IME support. #93021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riteo
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Sorry for the delay. Just gave a look and the code looks mighty fine!
I really appreciate that you did this with WaylandThread in mind, I realize that it's not very documented yet but nonetheless you managed to go along with it great! :D
Nothing looks out of place, although please note that I didn't test it and I don't know IMEs terribly well so TIWAGOS on the actual details.
Thank you so much for working on this!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements IME support via zwp_text_input_v3 protocol.
Fixes #92643
Not implemented (since it's not supported by other platforms and Godot DisplayServer API):
surrounding_text(it seems to be optional and not doing anything).1x10).I will refactor and unify virtual keyboard and IME
DisplayServerAPI for 4.4 and add support for this. For 4.3 it seems to be working fine without any of this (at least to the extent input is working on Wayland in general).