Fix Subviewport keeps using removed Camera3D child. #93377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jun 20, 2024
akien-mga
added
the
cherrypick:4.2
kleonc
requested changes
Jun 20, 2024
kleonc
approved these changes
Jun 20, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #92869
_camera_3d_remove()changedcamera_3ddirectly instead of calling_camera_3d_set(), which failed to change thecamerainRendererViewport. Now use_camera_3d_set()instead._.subviewport.tscn.-.Testing.-.Godot.Engine.2024-06-20.14-49-33.mp4