Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EGL macro check before using eglGetProcAddress() #93552

Closed
wants to merge 1 commit into from

Conversation

adamscott
Copy link
Member

Add a check for the macro definition EGL_ENABLED before using eglGetProcAddress().

Relates to #87981, where I thought that eglGetProcAddress() would have been used by the web platform. After more checks, it shouldn't be used.
Complements #93489 for the same reason.

@adamscott adamscott added this to the 4.3 milestone Jun 24, 2024
@adamscott adamscott requested a review from a team as a code owner June 24, 2024 13:20
@adamscott adamscott marked this pull request as draft June 24, 2024 13:24
@dsnopek
Copy link
Contributor

dsnopek commented Jun 24, 2024

The change in this PR is unnecessary in the context of the Web.

The code in question is already wrapped in #ifdef CAN_DEBUG, and CAN_DEBUG already won't be defined on the web. See:

#if !defined(IOS_ENABLED) && !defined(WEB_ENABLED)
// We include EGL below to get debug callback on GLES2 platforms,
// but EGL is not available on iOS.
#define CAN_DEBUG
#endif

@adamscott
Copy link
Member Author

Not useful as stated by @bruvzg on the developers chat and by @dsnopek's comment.

@adamscott adamscott closed this Jun 24, 2024
@AThousandShips AThousandShips removed this from the 4.3 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants