Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unused category vboxes in inspector #93627

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

passivestar
Copy link
Contributor

@passivestar passivestar commented Jun 26, 2024

Only show category vboxes that have children (when a category has properties outside of any section) to prevent unnecessary margins mentioned in #93435

Before After
before after

Note: this has no effect on the default theme because the default theme has a separation of 0

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me although I'm not the team of interest.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 26, 2024

You can use show()/hide() instead of set_visible(). Also I think the comment is unnecessary.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 26, 2024
@akien-mga akien-mga merged commit d119e49 into godotengine:master Jun 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@passivestar passivestar deleted the inspector-unused-vboxes branch June 26, 2024 18:33
@programneer
Copy link
Contributor

When i use this fix, it makes all settings in Project/Editor Settings hidden except the ones in sub-categories.
I guess they should revert it or make a little better solution.

@passivestar
Copy link
Contributor Author

passivestar commented Jun 30, 2024

When i use this fix, it makes all settings in Project/Editor Settings hidden except the ones in sub-categories.
I guess they should revert it or make a little better solution.

Can't reproduce with the default editor/project settings, are you using some addons that extend editor/project settings?

@programneer
Copy link
Contributor

programneer commented Jul 1, 2024

...are you using some addons that extend editor/project settings?

No, i'm using 4.3.beta2 [b75f048] which is why that causes it.

The right engine with the wrong code can make all the difference in the environment.

@passivestar
Copy link
Contributor Author

No, i'm using 4.3.beta2

This commit isn't in beta2, it was merged 5 days ago

@programneer
Copy link
Contributor

This commit isn't in beta2

I mean, with the PR applied.

@passivestar
Copy link
Contributor Author

Can you check if it works on master for you?

@Mickeon
Copy link
Contributor

Mickeon commented Jul 1, 2024

Please open another separate issue if this persists. I have tested the current build of the engine myself and cannot experience this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants