Fix division by zero in aspect ratio calculation

[patwork]

Info

Fixes #93738

A simple approach that protects against division by zero. When local_rect.has_area() returns false, i.e. width or height (or both) is zero, the aspect ratio calculation is performed on values incremented by 1.

In other cases, division is performed on the original values because (example):

• 50.0 / 100.0 = 0.5
• (50.0 + 1.0) / (100.0 + 1.0) = 0,504950495049505

Notes

By the way, it appears that the object resizing algorithm does not update the current dimensions for aspect ratio calculation when the shift key is pressed. This results in the shape not being adjusted to the current dimensions but to the original ones from the start of the dragging.

[anniryynanen]

I reproduced the issue and confirm that this PR fixes it.

I think the approach is good and it shouldn't be at risk of causing other bugs. I might change the increment to a bigger number, now if a control has say, size (0, 50), starting to scale the width up from 0 makes the height quickly go offscreen. (Edit: Scratch that, it'd quickly go offsceen for (1, 50) too.)

[JekSun97]

I also confirm that this solves my problem.

[akien-mga]

Thanks!