Fix AnimationPlayer blend_times sorting
#93876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested and working locally with |
TokageItLab
approved these changes
Jul 3, 2024
|
Please squash the commits to follow PR workflow https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase |
JacobMillner
force-pushed
the
fix-blend-times-sorting
branch
from
6b466e6
to
2e73903
Compare
Modify BlendKey's sort to use AlphaCompare in order to create a deterministic sort Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
JacobMillner
force-pushed
the
fix-blend-times-sorting
branch
from
2e73903
to
825cb3e
Compare
akien-mga
changed the title
blend_times sorting
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76491
The current operator< for
BlendKeyscompares to/from pointers resulting in nondeterministic behavior. You can see this represented in the.tscnfile of anything with lots ofblend_timesresulting in file changes which leads to extra noise in your git commits.This PR uses
StringName::AlphaComparewhen making to/from comparisons in order preform a lexicographic order sort rather than one determined by memory location.