Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding a translation CSV results in errors on initial import for many types of resources #93919

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix adding a translation CSV results in errors on initial import for many types of resources #93919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions editor/editor_file_system.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2072,15 +2072,17 @@ void EditorFileSystem::update_files(const Vector<String> &p_script_paths) {
}

if (updated) {
_process_update_pending();
if (update_files_icon_cache) {
_update_files_icon_path();
} else {
for (EditorFileSystemDirectory::FileInfo *fi : files_to_update_icon_path) {
_update_file_icon_path(fi);
}
}
call_deferred(SNAME("emit_signal"), "filesystem_changed"); //update later
if (!is_scanning()) {
_process_update_pending();
call_deferred(SNAME("emit_signal"), "filesystem_changed"); //update later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
call_deferred(SNAME("emit_signal"), "filesystem_changed"); //update later
call_deferred(SNAME("emit_signal"), "filesystem_changed"); // Update later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about this before merging. That will be for the next PR in that code :D

}
}
}

Expand Down
Loading