Fix custom Ctrl-Space shortcut in Script Editor adds a space #94033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Hilderin
force-pushed
the
fix-ctrl-space-script-editor-add-space
branch
from
1bd4a6c
to
f20ee48
Compare
akien-mga
reviewed
Jul 7, 2024
editor/editor_node.cpp
Outdated
| @@ -317,35 +317,40 @@ void EditorNode::shortcut_input(const Ref<InputEvent> &p_event) { | |||
|
|
|||
| Ref<InputEventKey> k = p_event; | |||
| if ((k.is_valid() && k->is_pressed() && !k->is_echo()) || Object::cast_to<InputEventShortcut>(*p_event)) { | |||
| EditorPlugin *old_editor = editor_plugin_screen; | |||
|
|
|||
| bool is_handled = false; | |||
There was a problem hiding this comment.
How about defaulting to true and only setting it to false in a final else?
Should save a bunch of repetition.
There was a problem hiding this comment.
Lol! So simple, really better! That's brilliant!! :)
Done!
Hilderin
force-pushed
the
fix-ctrl-space-script-editor-add-space
branch
from
f20ee48
to
a7c4522
Compare
akien-mga
approved these changes
Jul 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
get_tree()->get_root()->set_input_as_handled()was not called inEditorNode::shortcut_inputfor some shortcuts.It's not the most beautiful code, but I'm not sure how to make it better!!
Edit: was wrong issue.