Only print physics sync warning on dev builds to avoid warning spam from using move_and_slide
#94279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom using move_and_slide The check should be restored once we implement move_and_slide in a way that doesn't sync the physics thread
rburing
approved these changes
Jul 14, 2024
akien-mga
changed the title
move_and_slide
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around for the 4.3 release #94205
The check should be restored once we implement move_and_slide in a way that doesn't sync the physics thread
We can't do a full solution to #94205 for 4.3 since it will require big changes to
move_and_slide(). This PR hides the warning from users for now so we can fixmove_and_slide()and then re-enable the warning in 4.4 (ideally).This PR only impacts the physics server, the rendering server continues to have the check enabled.