Fix "selectable nodes at position clicked" feature in 3D editor

[mihe]

I just stumbled upon this one, so forgive the issue and PR rolled into one.

The viewport toolbar button titled "Show list of selectable nodes at position clicked", also triggered by Alt+RMB on Windows, is apparently broken (in 3D specifically) as of 97b8ad1, and as far as I can tell was broken by #92188.

The issue is hopefully apparent from looking at the change. The potential_selection_results could inherently never be incorporated into selection_results as its node would only be added to selection_results if selection_results.has(node), which doesn't make much sense.

This PR fixes that by inverting that if-check.

CC @SaracenOne.

[mihe]

@AThousandShips @akien-mga This should be labeled as a regression, and I would argue should be merged for 4.3. The list selection in 3D is just broken without it.

It would've been nice to get some input from the PR author, but the change seems relatively harmless to me.

[AThousandShips]

It is marked for 4.3, so it's likely going to be merged in 4.3 if nothing happens, but it needs a review by the relevant team

But will add regression

[akien-mga]

It is marked for 4.3, so it's likely going to be merged in 4.3 if nothing happens

But will add regression

In this case it's quite important to tag regressions accurately, as indeed they're the only bugs I care about at this stage. This would likely have been pushed to 4.4 this week as we're retriaging everything still in 4.3 if not re-reviewed correctly (I would have caught that it's a regression but maybe not all triagers would have).

[akien-mga]

I already started a build for 4.3.rc1 so this will be for rc2.

[AThousandShips]

In the future this would be helped by having a dedicated issue report as well clarifying when and what happened as it was somewhat vague from the description here

[mihe]

Fair enough. I'll avoid combining the issue and PR in the future.

[akien-mga]

Thanks!