-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve blend tree contrast/margins #94721
Improve blend tree contrast/margins #94721
Conversation
2d598ec
to
5525100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which cases does the regression appear? Could you upload an minimal reproduction project?
I'll try to make an MRP this weekend to check under what circumstances it happens, the only one that was clear was when opening and closing the resource picker in StateMachine nodes in blend trees. I'm not sure if it's something specific to this particular node (EditorResourceProperty) interacting with the graph node so I'll do some more digging |
5525100
to
9bcbcc8
Compare
I've done some testing, and I don't think the issue comes from the graph node itself, but rather something else that's not allowing the resize to trigger and make the node recalculate its size. For this particular specific case I've removed the minimum size change and added a fix that restores the original behavior in the blend trees graph, since I haven't seen anything else affected by this I think this is the path with the least friction, if slightly hacky |
I updated the PR title and description to reflect that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and tested this PR locally - looking good!
Currently, the embedded inspector of nodes seems to be broken (won't even show up with error Parameter "parent inspector" is null.
), but that's unrelated to this PR (verified).
9bcbcc8
to
5559075
Compare
Rebased, and I can confirm the embedded inspector is broken now, unrelated to the PR |
This PR fixes a problem that I recently noticed in my theme where progress bars with expanded margins wouldn't even fit within the nodes I had to remove expanded margins because of that, making all of the progress bars in the editor smaller. When this PR is merged I can make progress bars bigger again |
Thanks! |
Improved light theme contrast and readability by adding some margins and adjusting some theme stuff that I think might be leftovers from previous PRs that made adjustments to this.
Fixed graph nodes usingget_size()
instead ofget_minimum_size()
when they weren't resizable which could result in the nodes retaining their original size after changes. I could not find what exactly caused this regression since 4.2 but this seems like it should be the intended behavior anyhow, if the user can't resize the graph node, it should just adjust to its contents automatically.before_4_2.mp4
before_4_3.mp4
after.mp4