Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Use default aggregate initialization for NVAPI settings #94735

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

aitorciki
Copy link
Contributor

@aitorciki aitorciki commented Jul 25, 2024

Using the member initialization encouraged in NVAPI documentation for NVDRS_SETTING results in builds enabling dev_mode breaking:

platform/windows/gl_manager_windows_native.cpp: In member function 'void GLManagerNative_Windows::_nvapi_setup_profile()':
platform/windows/gl_manager_windows_native.cpp:246:56: error: missing initializer for member '_NVDRS_SETTING_V1::settingName' [-Werror=missing-field-initializers]
  246 |         NVDRS_SETTING ogl_thread_control_setting = { 0 };
      |                                                        ^

Default aggregate initialization results in a clean build though.

Initialy reported by @patwork in #93737 (comment).

@aitorciki
Copy link
Contributor Author

@Calinou @akien-mga pinging you directly since this fixes a category of builds broken by a previous PR.

@AThousandShips AThousandShips modified the milestones: 4.4, 4.3 Jul 25, 2024
Using the member initialization encouraged in NVAPI documentation for
NVDRS_SETTING results in builds enabling `dev_mode` breaking. Default
aggregate initialization results in a clean build though.
@aitorciki aitorciki force-pushed the nvdrs-memset-initialization branch from 2ca4b66 to 21f3e69 Compare July 25, 2024 12:42
@aitorciki aitorciki changed the title [Windows] Use memset to initialize NVAPI settings [Windows] Use default aggregate initialization for NVAPI settings Jul 25, 2024
@akien-mga akien-mga merged commit 44342c3 into godotengine:master Jul 26, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@aitorciki aitorciki deleted the nvdrs-memset-initialization branch July 26, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants