[Web] Gracefully handle non-finite audio volumes

[AThousandShips]

These values aren't valid but they should be handled gracefully, could handle with a isFinite() instead (though that would involve checking after converting, so bit more complex code), with or without a message, but I think this is the most straight forward way to handle it

This shouldn't happen with properly handled input, but in case of user error entering invalid values we should handle this gracefully instead of failing to load

• Closes: Uncaught TypeError: AudioParam.value setter error in Web build. #94806

[adamscott]

I think we can handle this case more gracefully than a try/catch. I'll try something in the following hour.

[AThousandShips]

I'll switch to a isFinite instead as an alternative, will push momentarily

[AThousandShips]

Now just ignores the value if non-finite after converting

Moving this to AudioServer could accidentally miss some cases though it would make it uniform and ignore any changes to such cases, by not even changing the audio bus volume, that would make it not change volume at all, currently (and before the introduction of samples) this would mute everything by the bus volume being invalid

But think a targeted fix would be appropriate here and looking at a broader fix with the possible implications later

[AThousandShips]

To confirm this just try running:

AudioServer.set_bus_volume_db(0, +INF)

and (separately):

AudioServer.set_bus_volume_db(0, NAN)

This will error out and fail to run, with a popup of the error Uncaught TypeError: AudioParam.value setter: Value being assigned is not a finite floating-point value.

With this fix, and specifically with isFinite it will work safely

[AThousandShips]

Here's an MRP to test with, check the script for instructions:

My bad uploaded wrong project:

webmrp.zip

[adamscott]

Here's an MRP to test with, check the script for instructions: WebMRP.zip

@AThousandShips Are you sure you joined the right MRP? There's no script at all.

[AThousandShips]

It's built-in

[adamscott]

Great work @AThousandShips. I didn't know that it was the WebAudio gain node that was complaining about Infinity.

So, everything's good, I'll add a warning later, that I must implement in the JS stack.

[akien-mga]

Thanks!

[AThousandShips]

Thank you!