Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fix is_process_running and kill for bundled apps. #94978

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 31, 2024

Fixes #94974

Note: there's no exit code for bundled apps, so it's not overridden, but I have added a note to the docs.

@bruvzg bruvzg added this to the 4.3 milestone Jul 31, 2024
@bruvzg bruvzg requested review from a team as code owners July 31, 2024 13:15
doc/classes/OS.xml Outdated Show resolved Hide resolved
@passivestar
Copy link
Contributor

Tested with my MRP, it works, thanks 🙏

@akien-mga akien-mga merged commit db414b6 into godotengine:master Jul 31, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS.is_process_running() returns false for a process created with OS.create_instance()
3 participants