GDScript: Fix unnecessary calls to remove_parser
#95115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+fix excessive memory allocations when 'load'ing many dependant scripts +fix excessive calls to vformat
rune-scape
force-pushed
the
fix-invalidated-parser
branch
from
138ce06
to
e680369
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
I can confirm that this pull request fixes #95076. |
akien-mga
changed the title
remove_parser
|
Thanks again @rune-scape for the quick reaction time, and @mihe for the extensive testing and regression reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+fix excessive memory allocations when
loading many dependant scripts+remove excessive calls to vformat
i suspect the call to
GDScriptCache::remove_parser()in~GDScriptParserRef()may have been responsible for how common the regressions from #92616 have been, i suspect it brought out the edgecases morefixes #95076