[ResourceLoader] Add check to prevent double free crashes. #95186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Aug 6, 2024
AThousandShips
approved these changes
Aug 6, 2024
|
Thanks! |
|
It's very likely the actual fix is included in #94169. That PR includes a fix for the nesting level. It may be that without it, it can reach zero multiple times so the element is tried to be freed multiple times as well. If this PR succeeds in preventing the crash, that's good for now. For completeness, let me mention that #93336 replaces the heap-allocated path stack with an in-class object. However, that's only about his it's lifecycle is managed, so if there's one PR potentially fixing the logic bug, that's not this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95138
It's probably not a complete fix, since if I understand correctly, this code should not be called if
load_paths_stackis already freed, but it's fixing the crash (tested on macOS, threaded loading seems to be working fine), and should not have any negative effects.