Fix Projection::invert for orthographic projection
#95303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:core
cherrypick:4.3
|
Do we have tests for this? If not, this PR should add some |
akien-mga
changed the title
Projection::invert for orthographic projection
EIREXE
force-pushed
the
inverted_composer
branch
from
65c8ccc to
2f08b7d
Compare
|
Added a few tests too |
EIREXE
force-pushed
the
inverted_composer
branch
from
2f08b7d to
3aa46b9
Compare
|
Made all expressions into their own lines and added back the accidentally removed test. |
clayjohn
reviewed
Aug 9, 2024
EIREXE
force-pushed
the
inverted_composer
branch
from
3aa46b9 to
3efcb0c
Compare
clayjohn
reviewed
Oct 3, 2024
|
Testing locally and I can confirm that this fixes the issue when using an orthographic projection. I also tested performance. With a debug build this version is quite a bit faster than the old version. With a release build there is no difference in performance. So we just need to decide what to do about the licensing, and then this should be fine to merge for 4.4 |
Spartan322
pushed a commit
to Spartan322/redot-engine
that referenced
this pull request
Oct 22, 2024
Relates to godotengine/godot#68878, specially when using orthographic projection. Also adds some tests. Adapted from godotengine/godot#95303 Co-authored-by: Álex Román <eirexe@eirteam.moe>
Spartan322
pushed a commit
to Spartan322/redot-engine
that referenced
this pull request
Oct 22, 2024
Relates to godotengine/godot#68878, specially when using orthographic projection. Also adds some tests. Adapted from godotengine/godot#95303
Spartan322
pushed a commit
to Spartan322/redot-engine
that referenced
this pull request
Oct 22, 2024
Relates to godotengine/godot#68878, specially when using orthographic projection. Also adds some tests. Adapted from godotengine/godot#95303
Spartan322
pushed a commit
to Spartan322/redot-engine
that referenced
this pull request
Oct 22, 2024
Relates to godotengine/godot#68878, specially when using orthographic projection. Also adds some tests. Adapted from godotengine/godot#95303 (cherry picked from commit 0773028)
EIREXE
force-pushed
the
inverted_composer
branch
from
3efcb0c to
2744d32
Compare
Fixes godotengine#68878, specially when using orthographic projection. Also adds some tests.
EIREXE
force-pushed
the
inverted_composer
branch
from
2744d32 to
02b2efc
Compare
clayjohn
approved these changes
Nov 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68878, specially when using orthographic projection.
Replaces our invert implementation with mesa's, which seems to work fine.