Make sure not to generate the compile_commands.json when not asked #95338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not create an issue for this, as the fix is pretty simple.
Scons seems to always generate the
compile_commands.json
, regardless of whether the flagcompiledb
is set or not, and even with an explicitcompiledb=no
.There are a whopping 3-4 seconds out of 6-10 seconds of build time saved on my machine when I don't need to recreate that file, which is pretty nice when iterating fast on small changes.