Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisplayServerWindows: Fix logic when creating with transient parent #95526

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

alvinhochun
Copy link
Contributor

This fixes some incorrect logic added in #94706.

I am not sure if this actually fixes anything though.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how it's related to #95068, this should not have any impact on GL.

@akien-mga akien-mga added this to the 4.4 milestone Aug 14, 2024
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 14, 2024
@akien-mga akien-mga modified the milestones: 4.4, 4.3 Aug 14, 2024
@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 14, 2024
@akien-mga
Copy link
Member

As this was confirmed to fix the issue, which is likely to affect quite a few users, we agreed with Clay to YOLO merge this now for 4.3.stable. Last commit in before release :)

@akien-mga akien-mga merged commit f27724e into godotengine:master Aug 14, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crashes when you minimize it (Windows, GL Compatibility, old Intel chipset)
3 participants