Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to PolygonPathFinder setup and is_point_inside methods #95782

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

andrei-g99
Copy link
Contributor

No description provided.

@andrei-g99 andrei-g99 requested a review from a team as a code owner August 19, 2024 00:00
@Calinou Calinou added enhancement documentation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 19, 2024
@Calinou Calinou added this to the 4.4 milestone Aug 19, 2024
@AThousandShips AThousandShips changed the title PolygonPathFinder class doc, added descriptions to setup() and is_point_inside() methods Add descriptions to PolygonPathFinder setup and is_point_inside methods Aug 19, 2024
@AThousandShips AThousandShips requested a review from a team August 19, 2024 08:42
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. It would be nice to squash your commits, although I feel like you have been using the online editor for these.

@akien-mga
Copy link
Member

CC @godotengine/dotnet if you can suggest C# versions of these code blocks.

@akien-mga
Copy link
Member

akien-mga commented Sep 3, 2024

Rebased to squash the commits, and added a C# example that seems to work.

@akien-mga akien-mga merged commit 293c0cb into godotengine:master Sep 3, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants