Fix resource loader not resolving shallow loaded scripts through dependencies (reverted) #96499
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
reviewed
Sep 3, 2024
beev1s
force-pushed
the
shallow-script-cache-error
branch
from
c97fdea to
fd5fc9f
Compare
dalexeev
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Looks reasonable to me. I tested it, this PR fixes the linked issue.
@beev1s Note that GitHub will not count this as your contribution. See GitHub Docs for details.
RandomShaper
approved these changes
Oct 22, 2024
RandomShaper
added
the
cherrypick:4.3
AThousandShips
changed the title
|
Thanks, and congratulations on your first contribution! 🎉 |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Feb 4, 2025
This reverts commit fd5fc9f. This caused significant regressions which are worse than the bug that godotengine#96499 aimed to address. - Reverts godotengine#96499. - Reopens godotengine#95909. - Supersedes godotengine#102063. - Fixes godotengine#99006. - Fixes godotengine#101615.
akien-mga
changed the title
|
Reverting with #102429 as this introduced complex regressions which are worse than the bug this was addressing. |
akien-mga
removed
the
cherrypick:4.3
sondredl
pushed a commit
to sondredl/godot
that referenced
this pull request
Feb 6, 2025
This reverts commit fd5fc9f. This caused significant regressions which are worse than the bug that godotengine#96499 aimed to address. - Reverts godotengine#96499. - Reopens godotengine#95909. - Supersedes godotengine#102063. - Fixes godotengine#99006. - Fixes godotengine#101615.
SirQuartz
pushed a commit
to SirQuartz/godot
that referenced
this pull request
Feb 7, 2025
This reverts commit fd5fc9f. This caused significant regressions which are worse than the bug that godotengine#96499 aimed to address. - Reverts godotengine#96499. - Reopens godotengine#95909. - Supersedes godotengine#102063. - Fixes godotengine#99006. - Fixes godotengine#101615.
dugramen
pushed a commit
to dugramen/godot
that referenced
this pull request
Feb 8, 2025
This reverts commit fd5fc9f. This caused significant regressions which are worse than the bug that godotengine#96499 aimed to address. - Reverts godotengine#96499. - Reopens godotengine#95909. - Supersedes godotengine#102063. - Fixes godotengine#99006. - Fixes godotengine#101615.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a script first gets shallow loaded through a dependency and and then requested by the resource loader, that script is already registered in
ResourceCacheand will therefore not be properly reloaded, which is necessary in order to resolve any Script inheritance. This can lead to errors when assigning objects with that script to a reference of its parent.GDScriptnow overwritesset_path_cachewhich does not register it in theRessourceCache.set_path_cachereplaces a call toset_pathinget_shallow_script.get_full_scriptnow callsset_pathto register the script.