ResourceLoader: Add last resort life-time insurance for tokens #96617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry-pick for 4.3 included in #96606. |
akien-mga
approved these changes
Sep 6, 2024
|
Needs rebase. |
RandomShaper
force-pushed
the
res_loader_pending
branch
from
924d829
to
ccd470d
Compare
|
Rebased! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to come in #94169, but when reorganizing the commits it got lost.
It makes sure that even if all the load requesters are no longer referencing a token, it's still alive until the corresponding load task completes so the task itself isn't removed until not even the resource loader itself is done with it. It's kinda an edge case.