Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken sky shader #96912

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix broken sky shader #96912

merged 1 commit into from
Sep 13, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Sep 12, 2024

Fix #96890

@Chaosus Chaosus requested a review from a team as a code owner September 12, 2024 13:52
@Chaosus Chaosus added this to the 4.4 milestone Sep 12, 2024
@Chaosus Chaosus force-pushed the shader_fix_sky branch 4 times, most recently from f52136d to 97b9a2a Compare September 12, 2024 14:07
@clayjohn
Copy link
Member

This fixes the sky shader, but it breaks the shader used to draw the origin lines:

This PR
Screenshot from 2024-09-12 14-21-11

Before this PR
image

4.4-dev2
Screenshot from 2024-09-12 14-23-58

@Chaosus
Copy link
Member Author

Chaosus commented Sep 13, 2024

@clayjohn Fixed, try again

@akien-mga akien-mga merged commit 74de05a into godotengine:master Sep 13, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_fix_sky branch September 13, 2024 11:39
@clayjohn
Copy link
Member

Tested locally and confirmed that this works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:rendering topic:shaders
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Default Sky shader doesn't render correctly
3 participants
@Chaosus @clayjohn @akien-mga