Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show GPU name when RenderingDevice is unsupported in the project creation dialog #97490

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 26, 2024

This helps diagnose issues on multi-GPU setups, particularly when only one of them supports RenderingDevice-based rendering methods.

This can be the case on old laptops with an Intell Haswell IGP and a NVIDIA Maxwell dedicated GPU, where the IGP does not support RenderingDevice but the dedicated GPU does. (In this case, Godot must be forced to run on the dedicated GPU to allow using RenderingDevice-based rendering methods.)

Preview

Ignore the GPU model name (it obviously supports Vulkan), I just changed the condition to get the dialog to show up.

Screenshot_20240926_153839

…tion dialog

This helps diagnose issues on multi-GPU setups, particularly when
only one of them supports RenderingDevice-based rendering methods.

This can be the case on old laptops with an Intell Haswell IGP
and a NVIDIA Maxwell dedicated GPU, where the IGP does not support
RenderingDevice but the dedicated GPU does.
(In this case, Godot must be forced to run on the dedicated GPU
to allow using RenderingDevice-based rendering methods.)
@dustdfg
Copy link
Contributor

dustdfg commented Sep 26, 2024

What will it say if I just forgot to install necessary vulkan packages in my package manager but GPU itself supports if?

@Calinou
Copy link
Member Author

Calinou commented Sep 26, 2024

What will it say if I just forgot to install necessary vulkan packages in my package manager but GPU itself supports if?

No, although you should not need to install specific packages to support Vulkan anyway. One exception is with the Nouveau driver (which doesn't support Vulkan outside of NVK), but you'll need to install the proprietary NVIDIA driver at this point, not just a Vulkan package.

@dustdfg
Copy link
Contributor

dustdfg commented Sep 26, 2024

What will it say if I just forgot to install necessary vulkan packages in my package manager but GPU itself supports if?

No, although you should not need to install specific packages to support Vulkan anyway. One exception is with the Nouveau driver (which doesn't support Vulkan outside of NVK), but you'll need to install the proprietary NVIDIA driver at this point, not just a Vulkan package.

What about MESA mesa-vulkan-drivers? I remember I couldn't run Godot with mobile or forward+ renderer before installed it and something like vulkan*

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@akien-mga akien-mga merged commit 1917bc3 into godotengine:master Oct 2, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the project-manager-rd-unsupported-show-gpu-name branch October 2, 2024 14:32
@dustdfg
Copy link
Contributor

dustdfg commented Oct 3, 2024

As I said it shows the error if there is no installed mesa-vulkan-drivers package
screen-1727940476

It is confusing because the gpu actually supports running rendering-device. I'd say error message isn't perfect though can't propose anything better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants