Expose CameraFeed setters #97534
Merged
Expose CameraFeed setters #97534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Sep 27, 2024
j20001970
force-pushed
the
camerafeed-setter
branch
from
1d2d402
to
38d7ec1
Compare
akien-mga
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Looks good to me!
I'll let @BastiaanOlij confirm as he implemented this class.
BastiaanOlij
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
The reasoning these were originally "private" was because we didn't want to expose these methods to normal users. They should only be called internally by the engine.
But that idea is very outdated by now as this indeed hinders their use from gdextension. So I think this change is fine.
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97504
In Godot 3.x,
CameraFeedsetters like_set_position,_set_RGB_imgare exposed to GDNative for implementing custom camera feeds, but they are no longer visible in GDExtension due to methods starting with underscore being ignored inextension_api_dump.cppThe PR simply removes underscore for these setters, exposing them to end users as the result. I'm not sure if there are better approach.