Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Improve cylinder gizmos #97535

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Editor: Improve cylinder gizmos #97535

merged 1 commit into from
Oct 25, 2024
+120 −91

Conversation

HolonProduction
Copy link
Member

Closes godotengine/godot-proposals#10214

Screencast.from.2024-09-27.12-56-56.mp4

@AThousandShips AThousandShips added this to the 4.x milestone Sep 27, 2024
SaracenOne
SaracenOne approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and yes, I think this is a sensible improvement to the behaviour of the gizmo. It might be worth adding similar behaviour to the capsules for consistency in the future, but I think this is fine to merge. 👍

AThousandShips
AThousandShips approved these changes Oct 11, 2024
View reviewed changes
editor/plugins/gizmos/gizmo_3d_helper.h Outdated Show resolved Hide resolved
@HolonProduction HolonProduction requested review from a team as code owners October 11, 2024 16:38
@Repiteo Repiteo modified the milestones: 4.x, 4.4 Oct 25, 2024
@Repiteo Repiteo merged commit 61accf0 into godotengine:master Oct 25, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Allow dragging top/bottom of Cylinder Shape and CSG Cylinder individually
5 participants
@HolonProduction @Repiteo @KoBeWi @SaracenOne @AThousandShips