Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vorbis: Remove redundant bounds check #97547

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Vorbis: Remove redundant bounds check #97547

merged 1 commit into from
Sep 28, 2024

Conversation

lalitshankarchowdhury
Copy link
Contributor

Remove bounds check because loop early exits on cursor >= size_t(file_data.size()).

@lalitshankarchowdhury lalitshankarchowdhury requested a review from a team as a code owner September 27, 2024 15:36
@AThousandShips AThousandShips added this to the 4.x milestone Sep 27, 2024
adamscott
adamscott approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright. I verified and it seems effectively that the check is already made at line 149.

@adamscott adamscott modified the milestones: 4.x, 4.4 Sep 27, 2024
@akien-mga akien-mga merged commit 0e2a76d into godotengine:master Sep 28, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@lalitshankarchowdhury lalitshankarchowdhury deleted the audio-code-fix branch September 29, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement topic:audio
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@lalitshankarchowdhury @akien-mga @adamscott @AThousandShips