Add caching to DisplayServer::can_create_rendering_device()
#97698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
reviewed
Oct 1, 2024
This greatly speeds up the method when using the Compatibility rendering method, where this method is not guaranteed to return `true` in that case.
Calinou
force-pushed
the
displayserver-can-create-rendering-device-add-caching
branch
from
6ec3545 to
6275370
Compare
|
Thanks! |
Calinou
deleted the
displayserver-can-create-rendering-device-add-caching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly speeds up the method when using the Compatibility rendering method, where this method is not guaranteed to return
truein that case.This is needed to ensure #97416 doesn't unnecessarily slow down the editor.