Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix untyped dictionary .NET debug visualization showing keys as values #97951

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

juanjp600
Copy link
Contributor

I couldn't find an issue talking about this, but this fix is so small that I figured I'd just submit it without an issue to link to.

Here's what Godot.Collections.Dictionary looks like in Rider's debugger:
image

With this fix, I get the expected result:
image

MRP: DictionaryDebugView.zip

@juanjp600 juanjp600 requested a review from a team as a code owner October 7, 2024 19:37
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@raulsntos raulsntos added bug topic:dotnet cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 8, 2024
@raulsntos raulsntos added this to the 4.4 milestone Oct 8, 2024
@Repiteo Repiteo merged commit 71fe3d9 into godotengine:master Oct 8, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants