Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET] Fix unhandled GD0303 error for nested generic attribute types #98059

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[.NET] Fix unhandled GD0303 error for nested generic attribute types #98059

merged 1 commit into from
Oct 14, 2024

Conversation

zaevi
Copy link
Contributor

@zaevi zaevi commented Oct 10, 2024

@zaevi zaevi requested a review from a team as a code owner October 10, 2024 14:43
@AThousandShips AThousandShips added bug topic:buildsystem topic:dotnet cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 10, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 10, 2024
raulsntos
raulsntos reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good. Can you add the fixed case to MustBeVariant.GD0301.cs? That way we verify that the PR fixes it and that we don't re-introduce the bug in the future.

@zaevi zaevi force-pushed the fix_csharp_unhandled_GD0303 branch from a129aea to 71ac3c0 Compare October 10, 2024 18:59
@zaevi zaevi force-pushed the fix_csharp_unhandled_GD0303 branch from 71ac3c0 to 9c99e51 Compare October 10, 2024 19:03
raulsntos
raulsntos approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Repiteo Repiteo merged commit c409546 into godotengine:master Oct 14, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 14, 2024

Thanks!

@zaevi zaevi deleted the fix_csharp_unhandled_GD0303 branch October 14, 2024 20:09
@jss2a98aj jss2a98aj mentioned this pull request Oct 19, 2024
Merged
@Spartan322 Spartan322 mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:buildsystem topic:dotnet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

GD0303 Error from MustBeVariantAnalyzer
4 participants
@zaevi @Repiteo @raulsntos @AThousandShips