Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use_native_dialog description in FileDialog #98202

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Update use_native_dialog description in FileDialog #98202

merged 1 commit into from
Oct 16, 2024

Conversation

syntaxerror247
Copy link
Contributor

@syntaxerror247 syntaxerror247 commented Oct 15, 2024 •
edited
Loading

Updated FileDialog class docs to represent changes in v4.3

After this PR #87303 there is no need to set access mode to ACCESS_FILESYSTEM.

@syntaxerror247 syntaxerror247 requested a review from a team as a code owner October 15, 2024 11:29
@AThousandShips AThousandShips added enhancement documentation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 15, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Oct 15, 2024
Loff3
Loff3 reviewed Oct 16, 2024
View reviewed changes
Copy link

@Loff3 Loff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarity improvement. I rephrased the sentence for better readability

doc/classes/FileDialog.xml Outdated Show resolved Hide resolved
@syntaxerror247 syntaxerror247 changed the title Update FileDialog class docs Update FileDialog class use_native_dialog description Oct 16, 2024
@syntaxerror247 syntaxerror247 changed the title Update FileDialog class use_native_dialog description Update use_native_dialog description in FileDialog Oct 16, 2024
@Repiteo Repiteo merged commit e4093b5 into godotengine:master Oct 16, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 16, 2024

Thanks!

@syntaxerror247 syntaxerror247 deleted the patch-1 branch October 16, 2024 23:15
@Spartan322 Spartan322 mentioned this pull request Oct 31, 2024
Merged
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Nov 11, 2024
@jss2a98aj jss2a98aj mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loff3 Loff3 Loff3 left review comments

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@syntaxerror247 @Repiteo @bruvzg @Loff3 @akien-mga @AThousandShips