-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix monochrome icon, add warning when it's not specified #98603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I’m not sure how I missed it! 😅
@Summersay415 Can you add a warning in |
Should I do this with adaptive background too? |
I don't think that's needed, default But in case of monochrome icon, I think it would be better to add this warning. It is a new feature, so it can be overlooked during export and it is not just a plane color insted I have added this warning in documentation, but most of the users don't read docs. CC @m4gr3d |
I should this warning in export window or just print in console? |
09c883c
to
a84292e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks! |
No need to backport this to 4.3; it has already been addressed in #100066 |
Fix small typo which resulted in setting adaptive background icon to monochrome one if monochrome is specified.