Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monochrome icon, add warning when it's not specified #98603

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Summersay415
Copy link
Contributor

Fix small typo which resulted in setting adaptive background icon to monochrome one if monochrome is specified.

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Contributor

@syntaxerror247 syntaxerror247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I’m not sure how I missed it! 😅

@syntaxerror247
Copy link
Contributor

@Summersay415 Can you add a warning in Export Present if monochrome icon is not provided.
Eg. No monochrome icon provided; default Godot monochrome icon will be used.

@Summersay415
Copy link
Contributor Author

@Summersay415 Can you add a warning in Export Present if monochrome icon is not provided.
Eg. No monochrome icon provided; default Godot monochrome icon will be used.

Should I do this with adaptive background too?

@syntaxerror247
Copy link
Contributor

syntaxerror247 commented Oct 29, 2024

I don't think that's needed, default adaptive background is just a plane color.

But in case of monochrome icon, I think it would be better to add this warning. It is a new feature, so it can be overlooked during export and it is not just a plane color insted Godot monochrome logo.

I have added this warning in documentation, but most of the users don't read docs.

CC @m4gr3d

@Summersay415
Copy link
Contributor Author

I should this warning in export window or just print in console?

@syntaxerror247
Copy link
Contributor

In export window, like we have for invalid pakage name.

image

@Summersay415
Copy link
Contributor Author

Summersay415 commented Oct 29, 2024

изображение
like this?

@Summersay415 Summersay415 changed the title Fix monochrome icon Fix monochrome icon, add warning when it's not specified Oct 29, 2024
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Repiteo Repiteo merged commit 5631039 into godotengine:master Nov 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 5, 2024

Thanks!

@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Nov 8, 2024
@Summersay415 Summersay415 deleted the live-is-monochrome branch November 9, 2024 05:39
@syntaxerror247
Copy link
Contributor

No need to backport this to 4.3; it has already been addressed in #100066

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants