Add vulkan error checks in command_queue_execute_and_present

[ducklin5]

This PR adds error checks for all possible errors that can arise from vkQueuePresentKHR

Currently when device_functions.QueuePresentKHR() returns an error, the error message looks like this:

ERROR: Condition "err != VK_SUCCESS && err != VK_SUBOPTIMAL_KHR" is true. Returning: FAILED
   at: command_queue_execute_and_present (drivers/vulkan/rendering_device_driver_vulkan.cpp:2344)

According to the vulkan docs (here): vkQueuePresentKHR returns one of these error values:

On success, this command returns:

    VK_SUCCESS
    VK_SUBOPTIMAL_KHR

On failure, this command returns:

    VK_ERROR_OUT_OF_HOST_MEMORY
    VK_ERROR_OUT_OF_DEVICE_MEMORY
    VK_ERROR_DEVICE_LOST
    VK_ERROR_OUT_OF_DATE_KHR
    VK_ERROR_SURFACE_LOST_KHR
    VK_ERROR_FULL_SCREEN_EXCLUSIVE_MODE_LOST_EXT

Note: VK_ERROR_OUT_OF_DATE_KHR is already handled in command_queue_execute_and_present.
So the error has to be one of these:

VK_ERROR_OUT_OF_HOST_MEMORY
VK_ERROR_OUT_OF_DEVICE_MEMORY
VK_ERROR_DEVICE_LOST
VK_ERROR_SURFACE_LOST_KHR
VK_ERROR_FULL_SCREEN_EXCLUSIVE_MODE_LOST_EXT

Unfortunately there's no way to know which error it is from the editor.
This PR ensures that the error message includes the error type to allow for further troubleshooting.

[clayjohn]

Instead of checking every condition it would be best to do the following:

1. print a string using ERR_FAIL_COND_V_MSG()
2. Create a function that takes in a VkResult and returns a string. The implementation of the function can be hidden behind an #ifdef DEBUG so that the full error handling is only done for debug builds. we use this pattern in a few places in the source (here for example:

   godot/drivers/gles3/storage/texture_storage.h

   Line 706 in 87318a2

   inline String TextureStorage::get_framebuffer_error(GLenum p_status) {

   )

[ducklin5]

After adding this messaging and running it on my project. I found out that I'm getting a VK_ERROR_DEVICE_LOST error for my particular case. (I think this is because my gdextension is stealing the device by calling vkCreateDevice for tensor processing... still not sure yet 🤷‍♂️ )

Anyway, I also noticed that command_queue_execute_and_present is handling the VK_ERROR_DEVICE_LOST error case for a previous call to vkQueueSubmit:

godot/drivers/vulkan/rendering_device_driver_vulkan.cpp

Line 2523 in e3534fd

if (err == VK_ERROR_DEVICE_LOST) {

I'm just wondering if we should be doing the same thing after the call to device_functions.QueuePresentKHR

[clayjohn]

I'm just wondering if we should be doing the same thing after the call to device_functions.QueuePresentKHR

I don't think so, that branch there is a special debug section to help us find out what was the last command in the command queue that ran before things crashed. In this case, we know the error came from QueuePresentKHR, so we don't need more information

[clayjohn]

It looks like this PR is failing on style checks. Here are our docs on our code style guidelines https://docs.godotengine.org/en/latest/contributing/development/code_style_guidelines.html#c-and-objective-c

Once you make those changes you will need to squash your commits together, how to do that is described here: https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase

[ducklin5]

Oh shoot, I assumed the PR would be squashed with the merge. Okay, I'll squash my commits. Thank you

[clayjohn]

Looks good to me! Thank you for making such quick changes

[ducklin5]

Thanks for the quick reviews!

[Repiteo]

Thanks! Congratulations on your first contribution! 🎉