Android: Refactor icon logic and make monochrome icon optional

[syntaxerror247]

Continuation of #97517

Monochrome icons are optional in Android, but our current implementation requires them to be included. This PR addresses that issue by disabling the monochrome icon if it is not provided in the export settings, giving developers greater flexibility and control.

Showcase video

First, I installed apk without providing monochrome icon. Second apk is with monochrome icon.

showcase_video.mp4

[m4gr3d]

@syntaxerror247 Unfortunately the approach will not work either for the gradle build or for the legacy build.

In both scenarios, you have to keep in mind that the adaptive icon is only used for api 26 and above; for apis lower than 26 (our min is 21), the apk uses the png mipmap resources and with your proposed fix, the manifest declaration will no longer match those png resources.

Here's how I think we can resolve this issue..

For the gradle build, you'll need to update icon.xml to add / remove the monochrome tag based on whether the user specified a monochrome icon or not.

For the legacy build, themed_icon.xml will need to be in the apk as well, while the default remains icon.xml (which does not contain a monochrome tag):

• If a monochrome icon is not specified, nothing to do
• If a monochrome icon is specified, then themed_icon.xml data should be retrieved from the apk, and used to overwrite icon.xml data similarly to how we overwrite the png resource data in

  godot/platform/android/export/export_plugin.cpp

  Line 3484 in 893bbdf

  if (file.ends_with(".png") && file.contains("mipmap")) {

[syntaxerror247]

In both scenarios, you have to keep in mind that the adaptive icon is only used for api 26 and above; for apis lower than 26 (our min is 21), the apk uses the png mipmap resources and with your proposed fix, the manifest declaration will no longer match those png resources.

Sorry I don't understand it, isn't our current implementation similar. I will admit I haven't tested with api 26 and older devices but I don't anticipate any issues.

godot/platform/android/java/app/AndroidManifest.xml

Line 21 in c8aca35

android:icon="@mipmap/icon"

For the gradle build, you'll need to update icon.xml to add / remove the monochrome tag based on whether the user specified a monochrome icon or not.

This approach aligns with what I was previously doing before resorting to directly modifying the file in the Manifest. I’ll switch to using this method instead.

If a monochrome icon is specified, then themed_icon.xml data should be retrieved from the apk, and used to overwrite icon.xml data similarly to how we overwrite the png resource data in

This is a great idea, I can just overwrite it :D. I will update the PR to use this method.

[m4gr3d]

In both scenarios, you have to keep in mind that the adaptive icon is only used for api 26 and above; for apis lower than 26 (our min is 21), the apk uses the png mipmap resources and with your proposed fix, the manifest declaration will no longer match those png resources.

Sorry I don't understand it, isn't our current implementation similar. I will admit I haven't tested with api 26 and older devices but I don't anticipate any issues.

In this version of the PR, the presence of a monochrome icon changes the android:icon declaration in both the gradle & legacy builds to android:icon="@mipmap/themed_icon".
The issue with that is that @mipmap/themed_icon does not match any of the png resources in the mipmap folders, and so on devices running api less than 26, the icon resource will not be resolvable.

[syntaxerror247]

In both scenarios, you have to keep in mind that the adaptive icon is only used for api 26 and above; for apis lower than 26 (our min is 21), the apk uses the png mipmap resources and with your proposed fix, the manifest declaration will no longer match those png resources.

Sorry I don't understand it, isn't our current implementation similar. I will admit I haven't tested with api 26 and older devices but I don't anticipate any issues.

In this version of the PR, the presence of a monochrome icon changes the android:icon declaration in both the gradle & legacy builds to android:icon="@mipmap/themed_icon". The issue with that is that @mipmap/themed_icon does not match any of the png resources in the mipmap folders, and so on devices running api less than 26, the icon resource will not be resolvable.

Now I understand, it would be an issue if a user enables monochrome and then uses the app on an older device and due to absence of icon App will falback to default Android icon. Thanks for clarifying!

[syntaxerror247]

Completely revamped the PR to address feedback and resolve issues with API 26 below devices. Also included a showcase video in the PR description.

[m4gr3d]

Looks great! I've added some comments to polish the PR, then it should be good to go!

Btw, can you take a look at #98622 and check that it would not interfere with this fix.

[m4gr3d]

Looks great!
Added a couple nitpick comments.

[Repiteo]

Thanks!