Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screen_get_scale documentation. #99677

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

syntaxerror247
Copy link
Contributor

@syntaxerror247 syntaxerror247 commented Nov 25, 2024

It was implemeted for these platforms over two years ago, but for some reason, the documentation was never updated!

float DisplayServerIOS::screen_get_scale(int p_screen) const {

float DisplayServerWeb::screen_get_scale(int p_screen) const {

float DisplayServerAndroid::screen_get_scale(int p_screen) const {

@syntaxerror247 syntaxerror247 marked this pull request as ready for review November 25, 2024 13:38
@syntaxerror247 syntaxerror247 requested a review from a team as a code owner November 25, 2024 13:38
@syntaxerror247 syntaxerror247 changed the title Update screen_get_scale documentation. Update screen_get_scale documentation. Nov 25, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Nov 25, 2024

When was this changed? Is it true?

@Mickeon Mickeon added this to the 4.4 milestone Nov 25, 2024
@Mickeon Mickeon requested a review from bruvzg November 25, 2024 14:04
@syntaxerror247
Copy link
Contributor Author

syntaxerror247 commented Nov 25, 2024

When was this changed? Is it true?

Yes, I'm not just randomly adding platforms! 😆

I have updated the PR description with references.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be implemented on all mentioned platforms.

@Repiteo Repiteo merged commit 539be43 into godotengine:master Nov 27, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 27, 2024

Thanks!

@syntaxerror247 syntaxerror247 deleted the patch-1 branch November 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants