feat: add tests for filter methods #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RetricSu
reviewed
Jul 7, 2022
RetricSu
reviewed
Jul 7, 2022
This was referenced Jul 8, 2022
RetricSu
reviewed
Jul 11, 2022
keroro520
force-pushed
the
filter-methods
branch
from
c87e0c3 to
9af9007
Compare
- This change enables interval-mining mode on Hardhat network. Without this, tx.wait(2) doesn't work(block waiting forever), as Hardhat won't mine new blocks when no new transactions sending. Ref: https://hardhat.org/hardhat-network/docs/explanation/mining-modes
keroro520
force-pushed
the
filter-methods
branch
from
9af9007 to
219fb5f
Compare
|
New features around Since tests on mainnet shouldn't waste too much capacity, right now most of test cases are disabled when testing on mainnet. Based on that, we should consider wether the new test case can be used for mainnet regression testing, and write conditional code for it. For example, if we think that the new test case shouldn't be used for tests on mainnet right now: const { isGwMainnetV1 } = require('../utils/network');
describe('...', () => {
if (isGwMainnetV1()) {
return;
}
...
}); |
|
Hi @ShookLyngs, thanks for your suggestion. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add some test cases for filter methods.
All of these cases pass on Hardhat network, but all fail on Godwoken network 😂