Support native transfer

[keroro520]

Web3 supports native transfer

When sending a native transfer transaction, appends to_address to polyjuice_args, uses POLYJUICE_CREATOR_ACCOUNT_ID as to_id;
when getting a native transfer transaction, extract to_address from polyjuice_args.

Indexer supports native transfer

For a native transfer transaction, extract to_address from polyjuice_args.

Related PRs

• feat: support native token transfer godwoken-polyjuice#173
• Validate native token transfer raw tx and signature godwoken#788

[RetricSu]

pls update https://github.com/nervosnetwork/godwoken-web3/blob/main/docs/compatibility.md#1-transactionto-must-be-a-contract-address as well

[RetricSu]

so right now eth_sendRawTransaction is good with EOA to address, what about eth_call and eth_estimateGas? Can they work with EOA to address now?

[keroro520]

so right now eth_sendRawTransaction is good with EOA to address, what about eth_call and eth_estimateGas? Can they work with EOA to address now?

The approach Web3 determines whether the transaction is native transafer tx: https://github.com/nervosnetwork/godwoken-web3/pull/505/files#diff-9b0dee551144978abbf32f56e4753f613c673ca1fce488d1d3f754556500f399R486-R500

/**
 * Determine whether the transaction is a native transfer transaction.
 *
 * When tx.to refers to an EOA account or an account that doesn't exist, it is considered a native transfer transaction.
 */
async function isEthNativeTransfer(
  { to: toAddress }: { to: HexString },
  rpc: GodwokenClient
): Promise<boolean> {
  if (toAddress.length === 42) {
    const toId = await getAccountIdByEthAddress(toAddress, rpc);
    return toId == null || isEthEOA(toAddress, toId, rpc);
  }
  return false;
}

For a tx that calling existed contract, the tx.to points to a contract, so isEthNativeTransfer returns false;
For a tx that calling nonexistant contract, the tx.to points to null, so isEthNativeTransfer returns true.

I have not test "eth_call and eth_estimateGas with EOA to address". In my opinion, if tx.to is EOA or null, it should be a native transfer tx, but not "call".

[RetricSu]

yes, but both eth_call and eth_estimateGas RPCs allow the to address to be an EOA address in Ethereum. Previously we reject such tx so it is incompatible, I want to make sure what is the behavior right now. I believe such tests are necessary. and it will be better if we can make it compatible.

[keroro520]

yes, but both eth_call and eth_estimateGas RPCs allow the to address to be an EOA address in Ethereum. Previously we reject such tx so it is incompatible, I want to make sure what is the behavior right now. I believe such tests are necessary. and it will be better if we can make it compatible.

Yes, we should use tests to enforce the compatibility. Later, I'll test it manually and give you feedback.
And I know @Dawn-githup is planning full test cases. cc @Dawn-githup

[keroro520]

pls update https://github.com/nervosnetwork/godwoken-web3/blob/main/docs/compatibility.md#1-transactionto-must-be-a-contract-address as well

done

[keroro520]

yes, but both eth_call and eth_estimateGas RPCs allow the to address to be an EOA address in Ethereum. Previously we reject such tx so it is incompatible, I want to make sure what is the behavior right now. I believe such tests are necessary. and it will be better if we can make it compatible.

Yes, we should use tests to enforce the compatibility. Later, I'll test it manually and give you feedback. And I know @Dawn-githup is planning full test cases. cc @Dawn-githup

Success to transfer to a payable contact.

[keroro520]

Update:

• The new commit 2c076ad allows eth_call/eth_estimateGas accept a native transfer tx. cc @RetricSu