Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mem-pool): remove re-injected failed txs in mem pool #831

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix(mem-pool): remove re-injected failed txs in mem pool #831

merged 1 commit into from
Nov 1, 2022

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Oct 27, 2022

No description provided.

@zeroqn zeroqn self-assigned this Oct 27, 2022
@zeroqn zeroqn requested a review from jjyr October 27, 2022 05:52
@gw-bot

This comment was marked as outdated.

Sign in to view
@zeroqn zeroqn requested review from Flouse and blckngm October 27, 2022 05:52
Flouse
Flouse requested changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@Flouse Flouse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run Result
failure

=> Please rebase on latest develop branch.

jjyr
jjyr previously approved these changes Oct 28, 2022
View reviewed changes
@zeroqn zeroqn force-pushed the fix-mem-pool-leftover-failed-reinject-txs branch from 589afb3 to 5042ac3 Compare October 31, 2022 07:24
@gw-bot
Copy link

gw-bot bot commented Oct 31, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 3359381785

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@zeroqn
Copy link
Contributor Author

zeroqn commented Oct 31, 2022

Run Result
failure

=> Please rebase on latest develop branch.

Done

@jjyr jjyr merged commit a80c899 into godwokenrises:develop Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@Flouse Flouse Flouse approved these changes

@jjyr jjyr jjyr left review comments

Assignees

@zeroqn zeroqn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeroqn @Flouse @jjyr @blckngm